Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle sources with same id from diff ingests #95

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

Saelmala
Copy link

There was an issue if you had two sources from different ingests but with the same source id in your production - if you changed the settings (alignment and latency) for one source, the other source got the same settings.

@Saelmala Saelmala self-assigned this Nov 13, 2024
@Saelmala Saelmala requested a review from malmen237 November 13, 2024 10:38
Copy link

@malmen237 malmen237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malmen237 malmen237 merged commit bcb2bc3 into main Nov 13, 2024
4 checks passed
@malmen237 malmen237 deleted the fix/handle-sources-same-id-diff-ingest branch November 13, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants