Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/handle-undefined-pipelineId-and-html-media-requests #90

Merged
merged 17 commits into from
Nov 12, 2024
Merged

Fix/handle-undefined-pipelineId-and-html-media-requests #90

merged 17 commits into from
Nov 12, 2024

Conversation

Saelmala
Copy link

This PR

  • Handles the issue of pipelineIds becoming undefined after a couple of rerenders
  • Handles the issue of output streams being deleted after a couple of rerenders
  • Handles the issue of pipelineIds being removed when saving output streams
  • Handles the issue of the requests for creation of HTML/Media expected different response format than what the API provides, therefore solving the problem with not being able to stop a production that contains these sources

@Saelmala Saelmala self-assigned this Nov 12, 2024
@Saelmala Saelmala requested a review from malmen237 November 12, 2024 08:51
malmen237
malmen237 approved these changes Nov 12, 2024
View reviewed changes
Copy link

@malmen237 malmen237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malmen237 malmen237 merged commit ad4476a into main Nov 12, 2024
4 checks passed
@malmen237 malmen237 deleted the fix/pipelinecard-inconsistency branch November 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malmen237 malmen237 malmen237 approved these changes

Assignees

@Saelmala Saelmala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saelmala @malmen237