Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed some unnecessary code and got layout-setup to work #78

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

malmen237
Copy link

@malmen237 malmen237 commented Nov 6, 2024

What does this fix?

  • The layout-modal shows up
  • Some code related to the old structure is removed
  • Available layouts gets populated and added to the layout-dropdown
  • A lot of resets is added to make the states and hooks behave as expected
  • Bug-fix from main is added to make "clear layout" set input-slot to 0
  • Set block from removing layouts saved in productions:
Skärmavbild 2024-11-07 kl  14 21 03 (2)

@malmen237 malmen237 marked this pull request as ready for review November 7, 2024 09:23
@malmen237 malmen237 requested a review from Saelmala November 7, 2024 09:23
Copy link

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one thing that should be fixed however before merge is that if I delete a layout, it still shows as an option in the multiview output layout dropdown. I need to refresh the browser for it to disappear.

src/i18n/locales/en.ts Outdated Show resolved Hide resolved
Saelmala

This comment was marked as resolved.

@malmen237 malmen237 requested a review from Saelmala November 8, 2024 10:15
@malmen237 malmen237 merged commit ef34b29 into refactor/RIPPP Nov 8, 2024
4 checks passed
@malmen237 malmen237 deleted the fix/make-mv-section-work branch November 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants