Add Fuzzing support and some fixes #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found from fuzzing
Found from fuzzing
Found from fuzzing
Found from fuzzing
Found from fuzzing
|
@eric Thanks for your contribution. I'm not keen on making the code completely stable to all sorts of input, but I think most of your changes are OK. Something that is not OK is the max size of the box. Mdat boxes can be larger than 4GB for 4K movies and other case, which is the reason that there is an 8-byte extended size. I'll look a bit more later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added fuzzing to test
mp4.DecodeBoxand discovered some issues with handling random/corrupted inputs.You can run the fuzzer with:
and it will continue to run until it finds any new issues. Right now the only thing that it's looking for is a panic. When it does find a new test case that fails, it puts it in
mp4/testdata/fuzz/FuzzDecodeBox/.