Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for prevalence patients and some perf improvements #59

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

9sneha-n
Copy link
Contributor

📌 References

📝 Implementation

Search for prevalence patients and some perf improvements

📹 Screenshots/Screen capture

Screenshot 2024-05-24 at 12 48 43 AM

🔥 Notes to the tester

@@ -115,10 +115,8 @@ const handleRuleFunctions = (condition: string): boolean => {
if (match) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(subjective) for beeing more redeable:

    if (!match) return false;
    const innerString = match[1];
    return innerString?.trim() === "" ? false : true;

Copy link

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n ! I've added a comment that does not affect to the functionality. Also super good to have seen examples of using Future.parallel and Future.join2

@MiquelAdell MiquelAdell merged commit a8a9b56 into development Jun 5, 2024
1 check passed
@MiquelAdell MiquelAdell deleted the feat/prev-search-perf-imp branch June 5, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants