Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Antibiotics in grid format and auto populate antibiotics on species select #35

Merged
merged 10 commits into from
May 14, 2024

Conversation

9sneha-n
Copy link
Contributor

@9sneha-n 9sneha-n commented Apr 24, 2024

📌 References

📝 Implementation

  1. On species change, pre populate all antibiotic options in grid
  2. handle AST Result or Value data entry
  3. On reset of species, reset antibiotic details.

📹 Screenshots/Screen capture

AutoPopulateGrid.mov

🔥 Notes to the tester

@9sneha-n 9sneha-n changed the base branch from master to development April 24, 2024 16:16
@9sneha-n 9sneha-n changed the base branch from development to fix/prevalence-patient-list April 24, 2024 16:50
Base automatically changed from fix/prevalence-patient-list to development April 25, 2024 12:02
@9sneha-n 9sneha-n marked this pull request as ready for review April 26, 2024 11:01
@9sneha-n 9sneha-n changed the title Feat/antobiotics grid Show Antibiotics in grid format and auto populate antibiotics on species select May 6, 2024
Copy link

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n I have added just one comment that it's more a question that a request of changes because I don't know the context of the task. Also nice the creation of components + hooks 🎉 (code-only review)

@9sneha-n
Copy link
Contributor Author

9sneha-n commented May 9, 2024

thanks @9sneha-n I have added just one comment that it's more a question that a request of changes because I don't know the context of the task. Also nice the creation of components + hooks 🎉 (code-only review)
thanks @anagperal

@9sneha-n 9sneha-n requested a review from anagperal May 9, 2024 17:41
Copy link

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n !

@MiquelAdell MiquelAdell merged commit ab56fe2 into development May 14, 2024
1 check passed
@MiquelAdell MiquelAdell deleted the feat/antobiotics-grid branch May 14, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants