Added Executor and increased timeout to help with stability #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,7 +196,7 @@ void open(HiveUgiArgs ugiArgs) { | |||
| // Wait before launching the next round of connection retries. | |||
| if (!isConnected && (retryDelaySeconds > 0) && ((attempt + 1) < retries)) { | |||
| try { | |||
| LOG.info("Waiting " + retryDelaySeconds + " seconds before next connection attempt."); | |||
| LOG.debug("Waiting " + retryDelaySeconds + " seconds before next connection attempt."); | |||
There was a problem hiding this comment.
does this log not help with detecting slow metastore issues ?
There was a problem hiding this comment.
I don't think so, we're already printing an info on line 124. This just adds to clutter imho.
Co-authored-by: Abhimanyu Gupta <[email protected]>
Co-authored-by: Abhimanyu Gupta <[email protected]>
abhimanyugupta07
approved these changes
Oct 24, 2023
javsanbel2
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.