Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update getCompletions document body #220

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

aliaksandr-trush
Copy link
Contributor

Newer language servers require absolute path to be part of the request.

Tested locally with language server 1.14.11.

Also replaced deprecated functions in utils module.

@saranshsaini
Copy link
Contributor

Just to clarify, was autocomplete not working before you added this?

@aliaksandr-trush
Copy link
Contributor Author

Just to clarify, was autocomplete not working before you added this?

Autocomplete works fine with the current language-server version (1.8.80)
But latest server versions require absolute-path parameter in a request.
So, after this PullRequest language-server could be upgraded for example to 1.14.11.

p.s. the latest language-server 1.16.18 throwing error "code":"unknown","message":"no absolute path"

@saranshsaini
Copy link
Contributor

Got it, thanks for your contribution! I'll merge that in.

Thanks for noting the error with 1.16, I believe I've found the error and will update the repo shortly.

@saranshsaini saranshsaini merged commit aa06fa2 into Exafunction:main Sep 23, 2024
2 checks passed
editor_language = filetype,
language = language,
cursor_offset = cursor_offset,
text = text,
curson_position = { row = cursor.row, col = cursor.col },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be cursor_position?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, thank you. I should have caught that. If you can, you can make a PR to fix it. Otherwise I can get to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants