Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug gpu #261

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Debug gpu #261

merged 6 commits into from
Oct 13, 2023

Conversation

jeremiedb
Copy link
Member

@jeremiedb jeremiedb commented Oct 13, 2023

  • fix performance regression from @sync in CUDA v5
  • fix unexported sigmoid funcion for logistic eval in CUDA extension

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (4458a63) 51.08% compared to head (c7fe1f0) 51.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   51.08%   51.00%   -0.08%     
==========================================
  Files          22       22              
  Lines        1985     1984       -1     
==========================================
- Hits         1014     1012       -2     
- Misses        971      972       +1     
Files Coverage Δ
ext/EvoTreesCUDAExt/eval.jl 0.00% <0.00%> (ø)
ext/EvoTreesCUDAExt/fit.jl 0.00% <0.00%> (ø)
ext/EvoTreesCUDAExt/init.jl 0.00% <0.00%> (ø)
ext/EvoTreesCUDAExt/fit-utils.jl 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremiedb jeremiedb merged commit 535b0c4 into main Oct 13, 2023
4 of 8 checks passed
@jeremiedb jeremiedb deleted the debug-gpu branch October 13, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant