Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment between DLD data and external pulse information #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philsmt
Copy link
Collaborator

@philsmt philsmt commented Nov 30, 2024

While most people use the DLD's internal pulse information, the component also supports supplying a PulsePattern object from the outside. Then, it may be necessary to align them.

The code supposed to handle that was unfortunately not working properly, as restricting entry_counts to only those rows with data before can easily cause the condition below to not properly activate. As a matter of fact, the test written for exactly this line hapened to pass because while it contained more trains, those had no pulses...

@bj-s

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.92%. Comparing base (9544407) to head (68eb929).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   73.93%   73.92%   -0.01%     
==========================================
  Files          23       23              
  Lines        2996     2995       -1     
==========================================
- Hits         2215     2214       -1     
  Misses        781      781              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant