Fix alignment between DLD data and external pulse information #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most people use the DLD's internal pulse information, the component also supports supplying a
PulsePattern
object from the outside. Then, it may be necessary to align them.The code supposed to handle that was unfortunately not working properly, as restricting
entry_counts
to only those rows with data before can easily cause the condition below to not properly activate. As a matter of fact, the test written for exactly this line hapened to pass because while it contained more trains, those had no pulses...@bj-s