Fixed Zombie update errors #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues:
- `browser.field('referrer').value` has been deprecated and changed to `browser.referrer`
- `browser.clickLink()` has been deprecated and changed to `browser.link()`
- You must put `done()` at the end of all tests due to their async nature
Issues:
- `browser.field('referrer').value` has been deprecated and changed to `browser.referrer`
- `browser.clickLink()` has been deprecated and changed to `browser.link()`
- You must put `done()` at the end of all tests due to their async nature
Fixes broken code from Zombie function deprecations
CamGrover
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Thank you! These changes helped clear some errors I had. I am questioning the multiple uses of done( ) but I do not understand enough to be certain. When I removed the done( ) from within the browser.link( ' . ' , function( ){ }) arguments the results seemed to most accurately display passed tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed and replaced all deprecated functions.
Issues fixed:
browser.field('referrer').valuehas been deprecated and changed tobrowser.referrerbrowser.clickLink()has been deprecated and changed tobrowser.link()done()at the end of all tests due to their async nature