Chapter 2 included. #106
Open
Chapter 2 included. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanRBrown
requested changes
Jun 18, 2018
| // making a node server which will listen at port 3000 | ||
| http.createServer(function(req,res){ | ||
| res.writeHead(200,{'Content-Type':'text/plain'}); //content type is text plain which refers to plain text | ||
| res.end('hello world'); |
There was a problem hiding this comment.
Lines 5 & 6 should be indented.
| @@ -0,0 +1,24 @@ | |||
| /* Example-1 */ | |||
There was a problem hiding this comment.
Are these both example 1 in the book? I don't have it in front of me, but that seems unlikely. I didn't intend to include all of the tiny examples in the repo, but I don't have a particular objection to it, either. Maybe the files should be named according to the correct example number? Like example-2.1.js, etc? Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapter 2 programs included which deals with routing principles and simple server program.