allow editing calendar on existing events

[jonas-haeusler]

these changes have been lying around for some time, finally found the time to finalize them and create this merge request.

in essence, this will just delete the old event and recreate it with a new id in the new calendar.
please test thoroughly and let me know if something is unclear.

fixes a bunch of open (duplicated) issues, here a few i found while quickly scanning the backlog:
fixes #62
fixes #101
fixes #812
fixes #1266
fixes #1400
fixes #1410

and also fixes #1351 and fixes #1134: the color picker is now hidden if the calendar does not provide any colors.

[Gitsaibot]

Thank you for the pull request. I think many have been waiting for this ;).

@ALL It would help us if many test these changes. The more test it in advance the faster we can create a new version.
Here is the link to the apk: https://github.com/Etar-Group/Etar-Calendar/actions/runs/5603553145

[jpggithub]

Hi
I try the apk on lineage kuntao 18.1 (android 11).
I can edit an event and change the calendar without problem.

[Luensche]

After a quick test: Everything looks fine. :)

[dumblob]

Is this transactional? I.e. using two-phase commit (i.e. first creating a copy in the destination calendar, and if successful, then removing the original).

[jonas-haeusler]

no, currently, the existing event is deleted and then the new event is inserted. should the deletion fail, the event is lost. i agree that this is suboptimal, and first inserting and only deleting on success would already provide a safety net. i don't know how easy (or not) this would be to implement. sadly, we can't just slap @transactional on here :-(

on another note: changing the calendar on a recurring event seems to be broken right now. this will require some more work...

[BalooRJ1]

Thank you for implementing this! Looking forward to seeing it pushed to the final version.

[Cwpute]

Thank you for the pull request. I think many have been waiting for this ;).

@ALL It would help us if many test these changes. The more test it in advance the faster we can create a new version. Here is the link to the apk: https://github.com/Etar-Group/Etar-Calendar/actions/runs/5603553145

Tested on Android 11, Nokia TA-1157: it works too!

[mgw2013]

Happy to test but would need a link.

[Gitsaibot]

@mgw2013 All you have to do is look under Actions where you will find the workflows and the appropriate apk. But here is the link https://github.com/Etar-Group/Etar-Calendar/actions/runs/6519434058

[kerbless]

in essence, this will just delete the old event and recreate it with a new id in the new calendar.

Is this really the only way to do this?

[Gitsaibot]

Ready for testing or is something still missing?

[jonas-haeusler]

recurring events should currently work okay-ish (i think there were some problems with recurrence exceptions when moving them to local/synced calendars) and the whole thing is now transactional, so all or nothing, which is nice.

i currently don't know how to proceed with the todo here, as this method is not available before api level 30 and there seems to be no easy workaround for that. maybe the moving of recurring events should just be disabled for now (or for users of api level <30) to get this merged?

[Gitsaibot]

I think moving recurring events for users of api level 30 would be a good solution. If there are problems for users >api 30 with recurring events, we can still deactivate it for everyone. Would that be feasible?

@jspricke What do you think?

[jspricke]

Enabling it for API 30 only would be fine with me.

[myshen]

Tested on Android 14, Samsung Galaxy. works great!

[Gitsaibot]

Ready to review?

[jonas-haeusler]

Ready to review?

sorry for the late reply. yes, this is ready for review and testing. if possible, I would appreciate if you could test moving events between calendars (of different providers if possible, and local/synced calendars) and check whether all event properties stay as expected. thank you!

[Gitsaibot]

At a first glance: editEventLayout seems to be broken. The vertical alignment does not fit and the calendar name is no longer displayed at all in the black theme.

[Gitsaibot]

What I also noticed is that if you change the privacy setting and the calendar at the same time, for example, this setting is not applied.

[Gitsaibot]

Apart from the two things mentioned above, I haven't noticed anything else so far. Can you have a look? It would be cool if we could complete the PR before it's one year old ;)

[mgw2013]

Would love but can't locate the .apk for testing purposes. Might be me or this mobile client...

[jonas-haeusler]

Apart from the two things mentioned above, I haven't noticed anything else so far. Can you have a look? It would be cool if we could complete the PR before it's one year old ;)

@Gitsaibot these issues should now be fixed (amongst a few others). if you find the time, please retest and let me know whether it is working for you.

i hope that recurrences are mostly working now. they were a lot harder to get right than i expected.
in fact, one case that is currently still broken is if a recurrence is synced with the EXDATE property set, and then the start time of the recurrence is changed by Etar, then this change does not currently update the start time within the EXDATE property, effectively removing any exceptions defined by EXDATE. however, adding EXDATE support is out of scope for this imo.

Would love but can't locate the .apk for testing purposes. Might be me or this mobile client...

@mgw2013 see https://github.com/Etar-Group/Etar-Calendar/actions/runs/9357933167.

[Gitsaibot]

Thank you very much, I will test it as soon as possible.

[mgw2013]

Just tried to move a single instance of a recurring event to another calendar - doesn't work. The drop down menu is greyed out.

However, moving the entire series to another calendar works, which is much appreciated! -mgw

[mgw2013]

Uhhh....it looks like the changes are not replicated via WebDav to the host...waited for several minutes and issued several sync requests on all devices. -mgw

[jonas-haeusler]

Just tried to move a single instance of a recurring event to another calendar - doesn't work. The drop down menu is greyed out.

yeah, I disabled moving single instances out of recurrences, as this would be a lot more work. its currently either all or nothing.

it looks like the changes are not replicated via WebDav to the host

can you please tell me how your setup looks like? which sync provider do you use on android and which caldav server software are you running?

[mgw2013]

can you please tell me how your setup looks like? which sync provider do you use on android and which caldav server software are you running?
Android 14 May w/ sec update DAVx5 from F-Droid. Calendar on GMX mail system - not sure what they r using.

Anyhow - I did a new test - it just takes a longer time to replicate the changes to the host and vice versa. So things r working as designed but slow.

[Gitsaibot]

Tested with google and nextcloud calendar so far I could not find any obvious errors.

So things r working as designed but slow.

The change of the calendar is executed directly in Etar how fast the changes are synchronized with online calendars etc. is not in the hands of Etar.

[Gitsaibot]

@jspricke Any objections? Otherwise I would merge it later and create a new version.

[szaimen]

🎉🎉🎉🎉🎉

[mgw2013]

Good job! Txs for ur effort - much appreciated

[wilhelmy]

Awesome, thank you @jonas-haeusler!