Use Integer.MIN_VALUE for preference "No Reminders" instead of -1

Etar-Group · Oct 27, 2023 · 710ecae · 710ecae
1 parent abe5386
commit 710ecae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/src/main/java/com/android/calendar/event/EventViewUtils.java b/app/src/main/java/com/android/calendar/event/EventViewUtils.java
@@ -50,7 +50,7 @@ public static String constructReminderLabel(Context context, int minutes, boolea
         Resources resources = context.getResources();
         int value, resId;
 
-        if (minutes < 0) {
+        if (minutes == Integer.MIN_VALUE) {
             value = 0;
             resId = R.string.no_reminder_label;
 

diff --git a/app/src/main/java/com/android/calendar/settings/GeneralPreferences.kt b/app/src/main/java/com/android/calendar/settings/GeneralPreferences.kt
@@ -529,8 +529,8 @@ class GeneralPreferences : PreferenceFragmentCompat(),
         const val KEY_ALERTS_POPUP = "preferences_alerts_popup"
         const val KEY_SHOW_CONTROLS = "preferences_show_controls"
         const val KEY_DEFAULT_REMINDER = "preferences_default_reminder"
-        const val NO_REMINDER = -1
-        const val NO_REMINDER_STRING = "-1"
+        const val NO_REMINDER = -2147483648
+        const val NO_REMINDER_STRING = "-2147483648"
         const val REMINDER_DEFAULT_TIME = 10 // in minutes
         const val KEY_USE_CUSTOM_SNOOZE_DELAY = "preferences_custom_snooze_delay"
         const val KEY_DEFAULT_SNOOZE_DELAY = "preferences_default_snooze_delay"

diff --git a/app/src/main/res/values/arrays.xml b/app/src/main/res/values/arrays.xml
@@ -88,7 +88,7 @@
     </integer-array>
 
     <string-array name="preferences_default_reminder_values" translatable="false">
-        <item>"-1"</item>
+        <item>"-2147483648"</item>
         <item>"0"</item>
         <item>"1"</item>
         <item>"5"</item>