Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated maplibre-gl dependency to v3.3.1, passing all tests #201

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

sdthaker
Copy link
Contributor

@sdthaker sdthaker commented Oct 6, 2023

I've updated the dependency to v3.3.1, which happens to be the latest and also ran the tests. The results are attached below. Please let me know if I'm missing anything else since this is my very first time contributing to an open-source repo! :)

Test results after upgrading the maplibre-gl dependency to v3.3.1:
image

Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavinr this looks good be since there are no direct breaking changes for us I wonder if we should make this peer dependency something like ^2.0.0 || ^3.0.0 so show that we can support v2 OR v3 of MapLibre right now.

@gavinr-maps
Copy link
Contributor

gavinr-maps commented Oct 9, 2023

@patrickarlt sounds good. I made that change. So this would not be a breaking change for esri-leaflet-vector then, correct? So we can release this under v4.2.1 ?

@gavinr-maps gavinr-maps merged commit ea5654b into Esri:master Oct 18, 2023
9 checks passed
@gavinr-maps
Copy link
Contributor

This was released in v4.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants