Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for places pagination #1133

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Conversation

patrickarlt
Copy link
Contributor

RE: #1117

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (33aba89) 100.00% compared to head (4f979c6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1133   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          177       177           
  Lines         3245      3245           
  Branches       550       550           
=========================================
  Hits          3245      3245           
Files Coverage Δ
...ages/arcgis-rest-places/src/findPlacesNearPoint.ts 100.00% <ø> (ø)
...s/arcgis-rest-places/src/findPlacesWithinExtent.ts 100.00% <ø> (ø)
...es/arcgis-rest-places/test/mocks/nearPoint.mock.ts 100.00% <ø> (ø)
...arcgis-rest-places/test/mocks/withinExtent.mock.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrickarlt
Copy link
Contributor Author

@gavinr should be good now.

Copy link
Contributor

@gavinr-maps gavinr-maps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I was doing some final searching and did find one additional place: in demos\node-places-api\nearPoint.mock.json it's still using the old format - but I'll update all those demo files in a follow-up PR (#1134).

@gavinr-maps gavinr-maps mentioned this pull request Oct 10, 2023
@gavinr-maps gavinr-maps merged commit 7e6afd1 into main Oct 10, 2023
5 checks passed
@gavinr-maps gavinr-maps deleted the 1117-places-pagination branch October 10, 2023 15:45
@gavinr-maps gavinr-maps removed their assignment Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants