More robust smoke.rs #2334
Open
More robust smoke.rs #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbro
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
Remove explicit loop from smoke.rs in favor of block stream listener. * add `fn subscribe_blocks` to client * add some fail cases to process-compose.yml
tbro
force-pushed
the
tb/ci/test-reliability
branch
from
09b9932
to
8e2d6a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2140
This PR:
Makes smoke.rs more robust by removing explicit loop from smoke.rs in favor of block stream listener. Previously we relied on time based assertions by sleeping w/in a
loop. This is error prone because we never really know when a block will be produced. By subscribing to block stream, we can do any assertions when we receive a new header. This should rule out many timing issues.In addition this PR:
fn subscribe_blocksto client