Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2118 improving state updates tests related to state history retention period #2129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

2118 improving state updates tests related to state history retention period #2129

wants to merge 3 commits into from

Conversation

alysiahuggins
Copy link
Contributor

@alysiahuggins alysiahuggins commented Oct 8, 2024 •
edited
Loading

Closes #2118

This PR:

  • warps timestamps so that we can more accurately test the results of escapeHatch related functions
  • tests in a more realistic way by updating state history after each new state is added instead of just setting all the states, this way we can properly see the performance of the circular array with its stateHistoryFirstIndex
  • it also brought in changes to the LightClient.sol from other branches that have not been merged yet - these branches are related to the CommonPrefix audit

@alysiahuggins alysiahuggins linked an issue Oct 8, 2024 that may be closed by this pull request
improving state updates tests related to state history retention period #2118
Open
@alysiahuggins alysiahuggins marked this pull request as ready for review October 16, 2024 12:40
@alysiahuggins alysiahuggins requested review from Sneh1999 and removed request for philippecamacho, jbearer, ImJeremyHe and tbro October 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

@Sneh1999 Sneh1999 Awaiting requested review from Sneh1999

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improving state updates tests related to state history retention period
1 participant
@alysiahuggins