Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten memberships into a single type #3867

Merged
merged 17 commits into from
Nov 25, 2024
Merged

Flatten memberships into a single type #3867

merged 17 commits into from
Nov 25, 2024

Commits on Nov 20, 2024

  1. replace calls to Memberships

    Delete Memberships and replace functionality. Add some methods to
    `Membership` trait to deal w/ collapsing into one type both kinds of
    memberships (stake and DA).
    
      * avoid passing membership into `is_valid_cert
      * for DA, avoid proxying threshold through `Threshold` trait
      * remove `Topic` param from `Membership::new
      * Split cert impls by marker (#3891)
      * add membership methods to Cert trait
      * remove non-existent tests from justfile
    tbro committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5f41f11 View commit details
    Browse the repository at this point in the history
  2. conflict resolution

    tbro committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d74753e View commit details
    Browse the repository at this point in the history
  3. cleanup

    tbro committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    872ce5c View commit details
    Browse the repository at this point in the history
  4. conflict resolution

    tbro committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2d65fcc View commit details
    Browse the repository at this point in the history
  5. cargo fmt

    tbro committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d95b670 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3483bfd View commit details
    Browse the repository at this point in the history
  7. revert some unnecessary name changes

    We can keep the old name where we only have one membership type to
    keep the diff smaller.
    tbro committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4881cd8 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Configuration menu
    Copy the full SHA
    932fd0f View commit details
    Browse the repository at this point in the history
  2. Leaders are Leaders

    Always use quorum for leader selection
    tbro committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    36f2f13 View commit details
    Browse the repository at this point in the history
  3. remove clone

    tbro committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    178ff18 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d7b9242 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c6d30fb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    49e23cb View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Configuration menu
    Copy the full SHA
    08c794f View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. add TODO

    tbro committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f1d9e5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7aaf224 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85c76dd View commit details
    Browse the repository at this point in the history