-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten memberships into a single type #3867
Merged
Merged
Commits on Nov 20, 2024
-
Delete Memberships and replace functionality. Add some methods to `Membership` trait to deal w/ collapsing into one type both kinds of memberships (stake and DA). * avoid passing membership into `is_valid_cert * for DA, avoid proxying threshold through `Threshold` trait * remove `Topic` param from `Membership::new * Split cert impls by marker (#3891) * add membership methods to Cert trait * remove non-existent tests from justfile
Configuration menu - View commit details
-
Copy full SHA for 5f41f11 - Browse repository at this point
Copy the full SHA 5f41f11View commit details -
Configuration menu - View commit details
-
Copy full SHA for d74753e - Browse repository at this point
Copy the full SHA d74753eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 872ce5c - Browse repository at this point
Copy the full SHA 872ce5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d65fcc - Browse repository at this point
Copy the full SHA 2d65fccView commit details -
Configuration menu - View commit details
-
Copy full SHA for d95b670 - Browse repository at this point
Copy the full SHA d95b670View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3483bfd - Browse repository at this point
Copy the full SHA 3483bfdView commit details -
revert some unnecessary name changes
We can keep the old name where we only have one membership type to keep the diff smaller.
Configuration menu - View commit details
-
Copy full SHA for 4881cd8 - Browse repository at this point
Copy the full SHA 4881cd8View commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 932fd0f - Browse repository at this point
Copy the full SHA 932fd0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36f2f13 - Browse repository at this point
Copy the full SHA 36f2f13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 178ff18 - Browse repository at this point
Copy the full SHA 178ff18View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7b9242 - Browse repository at this point
Copy the full SHA d7b9242View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6d30fb - Browse repository at this point
Copy the full SHA c6d30fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49e23cb - Browse repository at this point
Copy the full SHA 49e23cbView commit details
Commits on Nov 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 08c794f - Browse repository at this point
Copy the full SHA 08c794fView commit details
Commits on Nov 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f1d9e5f - Browse repository at this point
Copy the full SHA f1d9e5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7aaf224 - Browse repository at this point
Copy the full SHA 7aaf224View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85c76dd - Browse repository at this point
Copy the full SHA 85c76ddView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.