Move data files to /usr/share on Linux #195
Conversation
* Fix whitespace at EOL and EOF; replace tabs * Normalize line endings
Combine the Android and non-Android implementations. Only difference now is the path to the waveform data. Remove arbitrarily-sized buffers and most C-style string handling function calls. Use native Qt string methods instead; this should improve memory safety.
Use QString::asprintf() instead of a buffer. Convert to a C string using qPrintable().
Skip installing the .exe and .bat files on Linux. Other platforms could also search QStandardPaths::AppDataLocation but I am not familiar with how they are packaged. The locations searched corresponds to $XDG_DATA_DIRS; prepend the right path to it when running from the AppImage container.
Fix the labrador -> Labrador symlink so that it's created in
${INSTALL_ROOT} when supplied; previously it was installed directly to
/usr/bin. This symlink may not be necessary anymore.
turboencabulator
force-pushed
the
paths
branch
from
18bfaa5 to
1308ebc
Compare
New list generated by matching up the output of `readelf -d /usr/bin/Labrador | grep NEEDED` with the available Debian packages.
Honestly, at this stage it's not something I'd want to merge. It's just too out of date and would be a lot of work to bring in. |
|
Well from the viewpoint of a single (overloaded) maintainer, I fully understand the answer but have you considered to ask some of the most active contributors to step in as co-maintainer(s)? |
|
Are you offering to co-maintain? |
|
yes, I was a product owner once upon a time |
|
Fantastic! How do I add you? |
|
@EspoTek may I suggest to reopen this PR too? |
|
I can take another look when I get a chance. I know the first two commits were added and later reverted for some unknown reason, but they made the rest somewhat simpler to review/understand. Those two might be the bulk of the differences. |
|
@turboencabulator thank you so much! |
Basic idea is to make it easier to create a native package on Linux, but the program is searching for data files relative to its own location. Instead use QStandardPaths to find the data files so we can place everything in their customary locations.
The last few commits fix some complaints by lintian for the Debian package.