Removed RevEngWizardHandler and updated ReverseEngineerHandler with Wizard code #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en navigate to prior page, make updates and generate files again.
|
@BillKrat I have published a new marketplace release, and will have a look at this PR soon. |
|
Are some of the Dialogs not used any more and can be removed? |
…y EfCoreModelDialog is no longer in use - removed
|
Good question, you may have been able to glean from the PR noise that I originally removed the dialogs only to discover during testing that they were used by other handlers. I restored them to complete testing and meant to come back to assess that; your question reminded me and below are the results of my research. I removed the EFCoreModelDialog and its view model [updated the PR] as it was the only dialog orphaned by wizard work. Note: I do reuse the same interface for the Wiz3_EFCoreModelDialog page.
|
…d by wizard work]
|
@BillKrat Just found a bug, that must be fixed berfore we can merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed preview reverse engineering menu, updated ReverseEngineerHandler with RevEngWizardHandler code [removed RevEngWizardHandler class].