This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Import default template args #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martong
force-pushed
the
import_default_templ_args
branch
from
ec8f774 to
a7ba003
Compare
Xazax-hun
reviewed
Mar 21, 2018
lib/AST/ASTImporter.cpp
Outdated
| @@ -4174,7 +4174,7 @@ Decl *ASTNodeImporter::VisitTemplateTypeParmDecl(TemplateTypeParmDecl *D) { | |||
| // is created. | |||
|
|
|||
| // FIXME: Import default argument. | |||
| return TemplateTypeParmDecl::Create(Importer.getToContext(), | |||
| auto ToD = TemplateTypeParmDecl::Create(Importer.getToContext(), | |||
martong
force-pushed
the
import_default_templ_args
branch
from
a7ba003 to
f2cc841
Compare
martong
force-pushed
the
import_default_templ_args
branch
from
f2cc841 to
e75e4b6
Compare
|
Added new test for this case: Added new test for VarTemplateDecl. |
balazske
reviewed
Mar 22, 2018
|
Can one of the admins verify this patch? |
|
Not important for a while, because all specializations/instantiations have the concrete parameter. We did not see any error caused by this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310