Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standardized naming for build files that respects gitignore #1817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccuser44
Copy link
Contributor

@ccuser44 ccuser44 commented Jan 5, 2025

This doesn't apply to the #releases build files because they are controlled by a Github secret. They should be standardized too with the Adonis_ prefix.

@ccuser44
Copy link
Contributor Author

ccuser44 commented Jan 5, 2025

I cannot test this myself btw. (Just an fyi)

@Dimenpsyonal
Copy link
Member

This doesn't apply to the #releases build files because they are controlled by a Github secret. They should be standardized too with the Adonis_ prefix.

ok well i cant do anything about that either

@ccuser44
Copy link
Contributor Author

ccuser44 commented Jan 5, 2025

This doesn't apply to the #releases build files because they are controlled by a Github secret. They should be standardized too with the Adonis_ prefix.

ok well i cant do anything about that either

That doesn't matter in regards of this pull request

@Dimenpsyonal Dimenpsyonal added the github GitHub workflows and documentation etc. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github GitHub workflows and documentation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants