Refactor regenerate-mlir-bindings.yml workflow #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pangoraw
reviewed
Oct 28, 2024
Comment on lines
29
to
31
| pkg"instantiate" | ||
| pkg"update" | ||
| pkg"precompile" |
There was a problem hiding this comment.
┌ Warning: The Pkg REPL mode is intended for interactive use only, and should not be used from scripts. It is recommended to use the functional API instead.
└ @ Pkg.REPLMode /opt/hostedtoolcache/julia/1.10.5/x64/share/julia/stdlib/v1.10/Pkg/src/REPLMode/REPLMode.jl:382
Also i think we dont want to update:
Suggested change
| pkg"instantiate" | |
| pkg"update" | |
| pkg"precompile" | |
| Pkg.instantiate() | |
| Pkg.precompile() |
There was a problem hiding this comment.
Yeah, I've never agreed with that message. I would argue that a script is an interactive use and that you shouldn't use it in a library which uses Pkg.
Anyway, we can change it. No problem.
There was a problem hiding this comment.
About update... I always call update by default. Update does more than the other commands and it has solved problems I had with the dependencies many times.
|
It seems that the problem is back (with this PR)? https://github.com/EnzymeAD/Reactant.jl/actions/runs/11555990929/job/32162656313#step:7:318 so we need the custom depot again 🤷 |
|
Up & running now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @Pangoraw