Move Julia bindings to MLIR dialects out of JLL (#166)

* Rename generated dialect file names

* Add dialect binding file generator script

* Generate dialect files

* Automatize dialect regeneration

* Fix paths

* Fix docs generation

.github/workflows/regenerate-dialects.yml

@@ -0,0 +1,32 @@
+name: Regenerate MLIR Dialects
+on:
+  schedule:
+    - cron: '0 0 * * *'
+  workflow_dispatch:
+jobs:
+  make:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      pull-requests: write
+    steps:
+      - uses: julia-actions/setup-julia@v1
+        with:
+          version: '1.10'
+      - uses: actions/checkout@v4
+        with:
+          ref: main
+      - run: julia deps/ReactantExtra/make-dialects.jl
+      - name: Create Pull Request
+        id: cpr
+        uses: peter-evans/create-pull-request@v6
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          commit-message: Regenerate MLIR Dialects
+          title: 'Regenerate MLIR Dialects'
+          branch: regenerate-dialects
+          delete-branch: true
+      - name: Check outputs
+        run: |
+          echo "Pull Request Number - ${{ steps.cpr.outputs.pull-request-number }}"
+          echo "Pull Request URL - ${{ steps.cpr.outputs.pull-request-url }}"

deps/ReactantExtra/BUILD

@@ -406,7 +406,7 @@ gentbl_cc_library(
     name = "BuiltinJLIncGen",
     tbl_outs = [(
             ["--generator=jl-op-defs", "--disable-module-wrap=0"],
-            "Builtin.inc.jl"
+            "Builtin.jl"
         )
     ],
     td_file = "@llvm-project//mlir:include/mlir/IR/BuiltinOps.td",
@@ -420,7 +420,7 @@ gentbl_cc_library(
     name = "ArithJLIncGen",
     tbl_outs = [(
             ["--generator=jl-op-defs", "--disable-module-wrap=0"],
-            "Arith.inc.jl"
+            "Arith.jl"
         )
     ],
     td_file = "@llvm-project//mlir:include/mlir/Dialect/Arith/IR/ArithOps.td",
@@ -434,7 +434,7 @@ gentbl_cc_library(
     name = "AffineJLIncGen",
     tbl_outs = [(
             ["--generator=jl-op-defs", "--disable-module-wrap=0"],
-            "Affine.inc.jl"
+            "Affine.jl"
         )
     ],
     td_file = "@llvm-project//mlir:include/mlir/Dialect/Affine/IR/AffineOps.td",
@@ -448,7 +448,7 @@ gentbl_cc_library(
     name = "FuncJLIncGen",
     tbl_outs = [(
             ["--generator=jl-op-defs", "--disable-module-wrap=0"],
-            "Func.inc.jl"
+            "Func.jl"
         )
     ],
     td_file = "@llvm-project//mlir:include/mlir/Dialect/Func/IR/FuncOps.td",
@@ -462,7 +462,7 @@ gentbl_cc_library(
     name = "EnzymeJLIncGen",
     tbl_outs = [(
             ["--generator=jl-op-defs", "--disable-module-wrap=0"],
-            "Enzyme.inc.jl"
+            "Enzyme.jl"
         )
     ],
     td_file = "@enzyme//:Enzyme/MLIR/Dialect/EnzymeOps.td",
@@ -476,7 +476,7 @@ gentbl_cc_library(
     name = "StableHLOJLIncGen",
     tbl_outs = [(
             ["--generator=jl-op-defs", "--disable-module-wrap=0"],
-            "StableHLO.inc.jl"
+            "StableHLO.jl"
         )
     ],
     td_file = "@stablehlo//:stablehlo/dialect/StablehloOps.td",
@@ -490,7 +490,7 @@ gentbl_cc_library(
     name = "CHLOJLIncGen",
     tbl_outs = [(
             ["--generator=jl-op-defs", "--disable-module-wrap=0"],
-            "CHLO.inc.jl"
+            "CHLO.jl"
         )
     ],
     td_file = "@stablehlo//:stablehlo/dialect/ChloOps.td",
@@ -504,7 +504,7 @@ gentbl_cc_library(
     name = "VHLOJLIncGen",
     tbl_outs = [(
             ["--generator=jl-op-defs", "--disable-module-wrap=0"],
-            "VHLO.inc.jl"
+            "VHLO.jl"
         )
     ],
     td_file = "@stablehlo//:stablehlo/dialect/VhloOps.td",

deps/ReactantExtra/make-dialects.jl

@@ -0,0 +1,18 @@
+for file in [
+    "Builtin.jl",
+    "Arith.jl",
+    "Affine.jl",
+    "Func.jl",
+    "Enzyme.jl",
+    "StableHLO.jl",
+    "CHLO.jl",
+    "VHLO.jl",
+]
+    run(
+        `bazel build --action_env=JULIA=$(Base.julia_cmd().exec[1]) --repo_env HERMETIC_PYTHON_VERSION="3.10" --check_visibility=false --verbose_failures //:$file`,
+    )
+    Base.Filesystem.cp(
+        joinpath(@__DIR__, "bazel-bin", file),
+        joinpath(dirname(dirname(@__DIR__)), "src", "mlir", "Dialects", file),
+    )
+end

docs/make.jl

@@ -2,17 +2,6 @@ pushfirst!(LOAD_PATH, joinpath(@__DIR__, "..")) # add Enzyme to environment stac
 
 using Reactant
 using Documenter
-using Reactant_jll
-
-struct TestRemote <: Remotes.Remote end
-Remotes.repourl(::TestRemote) = "https://github.com/JuliaBinaryWrappers/Reactant_jll.jl"
-function Remotes.fileurl(::TestRemote, ::Any, filename, linerange)
-    L1, L2 = first(linerange), last(linerange)
-    return "https://github.com/JuliaBinaryWrappers/Reactant_jll.jl/$(filename)#L$(L1)-$(L2)"
-end
-function Remotes.issueurl(::TestRemote, issue)
-    return "https://github.com/EnzymeAD/Reactant.jl/blob/$(issue)"
-end
 
 DocMeta.setdocmeta!(Reactant, :DocTestSetup, :(using Reactant); recursive=true)
 
@@ -30,19 +19,6 @@ for (_, name) in examples
     Literate.markdown(example_filepath, OUTPUT_DIR; documenter=true)
 end
 
-run(Cmd(`rm -rf .git`; dir=Reactant_jll.artifact_dir))
-run(Cmd(`git init`; dir=Reactant_jll.artifact_dir))
-run(Cmd(`git config user.name ReactantDocs`; dir=Reactant_jll.artifact_dir))
-run(Cmd(`git config user.email [email protected]`; dir=Reactant_jll.artifact_dir))
-run(
-    Cmd(
-        `git remote add origin https://github.com/EnzymeAD/Reactant.jl`;
-        dir=Reactant_jll.artifact_dir,
-    ),
-)
-run(Cmd(`git add -A`; dir=Reactant_jll.artifact_dir))
-run(Cmd(`git commit -m "Initial commit"`; dir=Reactant_jll.artifact_dir))
-
 examples = [
     title => joinpath("generated", string(name, ".md")) for (title, name) in examples
 ]
@@ -66,11 +42,6 @@ makedocs(;
         Reactant.MLIR.Dialects.builtin,
     ],
     authors="William Moses <[email protected]>, Valentin Churavy <[email protected]>",
-    remotes=Dict(
-        # Just non-repository directories
-        joinpath(@__DIR__, "..") => gh,
-        Reactant_jll.artifact_dir => TestRemote(),
-    ),
     sitename="Reactant.jl",
     format=Documenter.HTML(;
         prettyurls=get(ENV, "CI", "false") == "true",

src/mlir/Dialects.jl

@@ -16,10 +16,8 @@ function operandsegmentsizes(segments)
     return namedattribute("operand_segment_sizes", Attribute(Int32.(segments)))
 end
 
-for path in readdir(Reactant_jll.artifact_dir; join=true)
-    if endswith("inc.jl")(path)
-        include(path)
-    end
+for file in readdir(joinpath(@__DIR__, "Dialects"))
+    include(joinpath(@__DIR__, "Dialects", file))
 end
 
 end # module Dialects