Skip to content

Commit

Permalink
Fix 1.11 arg based gc rewrite (#2250)
Browse files Browse the repository at this point in the history
* Update transforms.jl

* Update transforms.jl

* Update transforms.jl

* Update transforms.jl

* Update transforms.jl
  • Loading branch information
wsmoses authored Jan 5, 2025
1 parent 1a6ff16 commit 2309abd
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions src/llvm/transforms.jl
Original file line number Diff line number Diff line change
Expand Up @@ -563,27 +563,28 @@ function nodecayed_phis!(mod::LLVM.Module)
while length(addrtodo) != 0
v = pop!(addrtodo)
base, toffset = get_base_and_offset(v)
if offset === nothing

if in(base, seen)
continue
end
push!(seen, base)
if isa(base, LLVM.PHIInst)
for (v, _) in LLVM.incoming(base)
push!(addrtodo, v)
end
continue
end
if offset === nothing
offset = toffset
else
if offset != toffset
all_args = false
break
end
end
if in(base, seen)
continue
end
push!(seen, base)
if isa(base, LLVM.Argument) && addrspace(value_type(base)) == 11
continue
end
if isa(base, LLVM.PHIInst)
for (v, _) in LLVM.incoming(base)
push!(addrtodo, v)
end
continue
end
all_args = false
break
end
Expand Down

2 comments on commit 2309abd

@wsmoses
Copy link
Member Author

@wsmoses wsmoses commented on 2309abd Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/122435

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.13.28 -m "<description of version>" 2309abd2fd510ab6b400df030f16004e8ca79512
git push origin v0.13.28

Please sign in to comment.