Skip to content

Commit

Permalink
Update validation.jl (#2243)
Browse files Browse the repository at this point in the history
  • Loading branch information
@wsmoses
wsmoses authored Dec 31, 2024
1 parent 883c777 commit 1b19f39
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/compiler/validation.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,9 @@ function check_ir!(@nospecialize(job::CompilerJob), errors::Vector{IRError}, imp
end
end
@assert FT !== nothing

initfn, _ = get_base_and_offset(LLVM.initializer(fn_got); offsetAllowed=false, inttoptr=false)
init = LLVM.initializer(fn_got)
if init !== nothing
initfn, _ = get_base_and_offset(init; offsetAllowed=false, inttoptr=false)
loadfn = first(instructions(first(blocks(initfn))))::LLVM.LoadInst
opv = operands(loadfn)[1]
if !isa(opv, LLVM.GlobalVariable)
Expand Down Expand Up @@ -433,6 +434,7 @@ function check_ir!(@nospecialize(job::CompilerJob), errors::Vector{IRError}, imp
LLVM.API.LLVMDeleteGlobal(fn_got)
end
end
end

elseif isInline
md = metadata(inst)
Expand Down

2 comments on commit 1b19f39

@wsmoses
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/122226

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.13.27 -m "<description of version>" 1b19f39382e4bc6f8d2aa544d69f65f9fff34eb1
git push origin v0.13.27

Please sign in to comment.