Update RainCounterIC2 to support reed-switch anemometer #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to a 32-bit count enables use with a reed-switch anemometer (EnviroDIY/TippingBucketRainCounter#4) and also fixes a bug described in EnviroDIY/TippingBucketRainCounter#5. Tested and works, including backward compatibility.
|
Please add your changes to the change log! |
|
@SRGDamia1, as this is a very simple PR (only 4 code files changed), and all checks passed, I'll merge this into develop. You'll get a chance to review it before releasing to Master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update was successfully deployed in April 2021 on both a Davis tipping bucket and an Inspeed reed-switch anemometer.
This PR updates
RainCounterIC2capabilities to fully support v0.2.0 of the EnviroDIY/TippingBucketRainCounter device firmware, which was updated for these features and fixes: