Fix spec and add spec for supra governance #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoshisupra
reviewed
Oct 28, 2024
| aborts_if !table::spec_contains(voting_forum.proposals, proposal_id); | ||
| aborts_if is_voting_period_over(proposal); | ||
| aborts_if proposal.is_resolved; | ||
| aborts_if !exists<timestamp::CurrentTimeMicroseconds>(@supra_framework); |
There was a problem hiding this comment.
@axiongsupra not sure why this aborts_if is required and what purpose does it serve.
There was a problem hiding this comment.
This is for checking the whether time already started. This is required if we have call to timestamp::now_seconds()
sjoshisupra
reviewed
Oct 28, 2024
| // }; | ||
| let timestamp_secs_bytes = std::bcs::serialize(timestamp::spec_now_seconds()); | ||
| let key = std::string::spec_utf8(RESOLVABLE_TIME_METADATA_KEY); | ||
| ensures simple_map::spec_get(post_proposal.metadata, key) == timestamp_secs_bytes; |
There was a problem hiding this comment.
This property only ensures that time is recorded. Other properties we should aim at adding are
- vote by the voter is recorded (if not already voted)
- vote by the voter is recorded (if vote is flipped)
- total yes/no votes should tally (increase/decrease appropriately)
sjoshisupra
reviewed
Oct 28, 2024
aptos-move/framework/supra-framework/sources/multisig_voting.spec.move
Outdated
Show resolved
Hide resolved
sjoshisupra
reviewed
Oct 28, 2024
Comment on lines
143
to
144
| aborts_if has_multi_step_key && !from_bcs::deserializable<bool>(simple_map::spec_get(proposal.metadata, multi_step_key)); | ||
| aborts_if has_multi_step_key && from_bcs::deserialize<bool>(simple_map::spec_get(proposal.metadata, multi_step_key)); |
There was a problem hiding this comment.
Not sure I understand the role of these. @axiongsupra
There was a problem hiding this comment.
This looks strange to me. I will take a look and submit a patch.
sjoshisupra
reviewed
Oct 28, 2024
|
|
||
| let post post_voting_forum = global<VotingForum<ProposalType>>(voting_forum_address); | ||
| let post post_proposal = table::spec_get(post_voting_forum.proposals, proposal_id); | ||
| aborts_if !exists<timestamp::CurrentTimeMicroseconds>(@supra_framework); |
There was a problem hiding this comment.
This is for checking the whether time already started. This is required if we have call to timestamp::now_seconds()
sjoshisupra
reviewed
Oct 28, 2024
sjoshisupra
reviewed
Oct 28, 2024
sjoshisupra
reviewed
Oct 28, 2024
sjoshisupra
reviewed
Oct 28, 2024
aptos-move/framework/supra-framework/sources/multisig_voting.spec.move
Outdated
Show resolved
Hide resolved
sjoshisupra
reviewed
Oct 28, 2024
sjoshisupra
reviewed
Oct 28, 2024
sjoshisupra
reviewed
Oct 28, 2024
sjoshisupra
reviewed
Oct 28, 2024
aptos-move/framework/supra-framework/sources/reconfiguration.spec.move
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.