Cherrypick branch #43
Conversation
so-kkroy22
force-pushed
the
cherrypick_branch
branch
from
8c5bbb5 to
8731880
Compare
…reation - also fixes execution order of ValidatorSet activation at genesis end
supra-yoga
force-pushed
the
cherrypick_branch
branch
from
4c1d1e8 to
c947348
Compare
aptos-move/vm-genesis/src/lib.rs
Outdated
| @@ -717,7 +742,7 @@ fn create_and_initialize_validators_with_commission( | |||
| let validators_bytes = bcs::to_bytes(validators).expect("Validators can be serialized"); | |||
| let mut serialized_values = serialize_values(&vec
There was a problem hiding this comment.
I think we would not be calling this function of genesis since we always use pool initialization function to initialize the validators, isn't it?
There was a problem hiding this comment.
Yep, this is a residue of an old approach. I'll undo this change.
| let operator_addrs6 = test_validators[6].data.operator_address; | ||
|
|
||
| // PBO winner | ||
| let pbo_account01 = AccountAddress::from_hex_literal("0x01").unwrap(); |
There was a problem hiding this comment.
Since 0x01 is the address of supra_framework I am not sure if this test would pass or whether it would create some problem. I think first 10 or 16 are system accounts and should not be used for testing addresses since the side effects of doing so are not well understood.
There was a problem hiding this comment.
This test was supposed to be rewritten from scratch again and is in WIP. I've #[ignore]-ed this test due to time constraints. Once the Release Candidate tag is published for upcoming rounds, I will raise another cleanup PR to get this test passing again.
Commit breakdown:
AccountBalancetype. Required for PBO data processing insmr-moonshot.smr-moonshotfor creating resource accounts.