[Automation] Enumerable map enhancements #148
Conversation
| } | ||
|
|
||
| /// Remove single Key from the Enumerable Map | ||
| public fun remove_value<K : copy+drop, V : store+drop+copy>(map: &mut EnumerableMap<K, V>, key: K) { | ||
| public fun remove_value<K: copy+drop, V: store+drop+copy>(map: &mut EnumerableMap<K, V>, key: K) { |
There was a problem hiding this comment.
@nizam-supraoracles I think it may be good to return the value being removed.
| public inline fun for_each_value<K: copy+drop, V: store+drop+copy>(set: &EnumerableMap<K, V>, f: |V|) { | ||
| let i = 0; | ||
| let len = length(set); | ||
| while (i < len) { | ||
| let key = *vector::borrow(&set.list, i); | ||
| f(table::borrow(&set.map, key).value); | ||
| i = i + 1 | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we also need for_each_value_mut also where a mutable reference of the value is passed to the function.
There was a problem hiding this comment.
We should also add for_each_keyval, where copies of key and value is provided to function (original data structure must not change).
| /// Filter the enumerableMap using the boolean function, removing all elements for which `p(e)` is not true. | ||
| public inline fun filter<K: copy+drop, V: store+drop+copy>(set: &EnumerableMap<K, V>, p: |&V|bool): vector<V> { | ||
| let result = vector<V>[]; | ||
| for_each_value(set, |v| { |
There was a problem hiding this comment.
I believe for_each_value_ref would be better here.
There was a problem hiding this comment.
We can use that; however, since the next step involves using the vector::push_back method, we need to handle pointer dereferencing with vector::push_back(&mut result, *v). Therefore, there doesn't seem to be a specific reason to use for_each_value_ref in this context.
There was a problem hiding this comment.
Looks good.
would it make sense to have filter_map option as well where it accepts 2 fucctions for filtering and then mapping the value and returns the vector of the mapped values.
this way for example automation_registry_state::get_active_task_ids can utilize this function.
@nizam-supraoracles , I agree, this is a good suggestion. We can certainly have a |
Resolve https://github.com/Entropy-Foundation/smr-moonshot/issues/1425