Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for modulable wrappers / Python2 support + SystemTags wrapper #69

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

luffah
Copy link

@luffah luffah commented May 3, 2021

Hello, sorry for the massive PR.

I refactored the code in order to dynamically add features on imported wrappers.
It shall ease creation of new wrappers outside this lib (custom apps) .

Too, i added what i needed:

  • python2 compatibility
  • wrapper for SystemTags

Lib API notable changes :

  • user_id removed from WebDav arguments (using main client user_id)

I polluted again the PR with some lints, documentation and moved confusing files.

Nextcloud.py -> __init__.py
nextcloud/Dockerfile  -> tests/Dockerfile

( Missing test for systemtags, so sorry )
Edit: related issues #67, #66, #68, #5
Changes include

  • addition of an option to set alternate auth method and usage as session (working with instruction with NextCloud as nxc: ; too login success is checked with exception)
  • addition of AUTHORS.rst
  • update requirements versions to allow to use plugin with pytest
  • moving descriptive content setup.py to setup.cfg; and add a shortcut to publish in PyPi (one day)
  • test.sh script

…b (custom apps) + python2 compatibility + addition of a wrapper for SystemTags + some lints and documentation
@luffah luffah force-pushed the master branch 9 times, most recently from e95e19d to a98e8bf Compare May 4, 2021 14:47
@luffah
Copy link
Author

luffah commented May 6, 2021

( @EnterpriseyIntranet Thank you for the free code inspection )

@luffah luffah force-pushed the master branch 4 times, most recently from d141a43 to 2fb222c Compare May 10, 2021 15:36
@luffah luffah force-pushed the master branch 4 times, most recently from 4894c01 to da8ae53 Compare May 20, 2021 18:26
@scrutinizer-notifier
Copy link

The inspection completed: 120 updated code elements

@luffah
Copy link
Author

luffah commented Jun 4, 2021

@EnterpriseyIntranet @matejak @danil-topchiy
FYI if the PR please you a little : i forked the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants