forked from Dosugamea/NEXT-OCS-API-forPy
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring for modulable wrappers / Python2 support + SystemTags wrapper #69
Open
luffah
wants to merge
9
commits into
EnterpriseyIntranet:master
Choose a base branch
from
luffah:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b (custom apps) + python2 compatibility + addition of a wrapper for SystemTags + some lints and documentation
luffah
force-pushed
the
master
branch
9 times, most recently
from
May 4, 2021 14:47
e95e19d
to
a98e8bf
Compare
…t methods : get_related_files
…recursive=True) to do that
( @EnterpriseyIntranet Thank you for the free code inspection ) |
luffah
force-pushed
the
master
branch
4 times, most recently
from
May 10, 2021 15:36
d141a43
to
2fb222c
Compare
…mtags + test.sh script to ease test
luffah
force-pushed
the
master
branch
4 times, most recently
from
May 20, 2021 18:26
4894c01
to
da8ae53
Compare
The inspection completed: 120 updated code elements |
@EnterpriseyIntranet @matejak @danil-topchiy
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, sorry for the massive PR.
I refactored the code in order to dynamically add features on imported wrappers.
It shall ease creation of new wrappers outside this lib (custom apps) .
Too, i added what i needed:
Lib API notable changes :
user_id
removed from WebDav arguments (using main client user_id)I polluted again the PR with some lints, documentation and moved confusing files.
( Missing test for systemtags, so sorry )Edit: related issues #67, #66, #68, #5
Changes include
with NextCloud as nxc:
; too login success is checked with exception)