Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial introduction of exceptions to requests. #48

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matejak
Copy link

@matejak matejak commented Dec 16, 2019

No description provided.

@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues, 11 updated code elements

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #48 into master will decrease coverage by 2.18%.
The diff coverage is 64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   92.71%   90.52%   -2.19%     
==========================================
  Files          17       17              
  Lines         563      623      +60     
==========================================
+ Hits          522      564      +42     
- Misses         41       59      +18
Impacted Files Coverage Δ
src/nextcloud/api_wrappers/apps.py 100% <100%> (ø) ⬆️
src/nextcloud/base.py 76% <60%> (-24%) ⬇️
src/nextcloud/api_wrappers/user_ldap.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3253a7c...60a099d. Read the comment docs.

@luffah
Copy link

luffah commented Apr 14, 2021

Note : This PR don't solve #5.

Maybe the PR will benefit of filling the description (with API reference source) and maybe associating it to a specific issue report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants