Support volume snapshot in TF #564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalsawale9
changed the title
vishalsawale9
force-pushed
the
UPM-34585
branch
2 times, most recently
from
dcb74ed to
25ea238
Compare
vishalsawale9
requested review from
edbamolvyavahare and
wai-wong-edb
and removed request for
edbamolvyavahare
wai-wong-edb
requested changes
Jul 25, 2024
|
Looks good. But we can merge after I merged v1. After I merge v1 there may need to be some rebasing/merging changes |
…-provider-biganimal into UPM-34585 # Conflicts: # examples/resources/biganimal_cluster/ha/resource.tf # examples/resources/biganimal_cluster/single_node/aws/resource.tf # examples/resources/biganimal_cluster/single_node/azure/resource.tf # examples/resources/biganimal_cluster/single_node/bah_aws/resource.tf # examples/resources/biganimal_cluster/single_node/bah_azure/resource.tf # examples/resources/biganimal_cluster/single_node/bah_gcp/resource.tf # examples/resources/biganimal_cluster/single_node/gcp/resource.tf # examples/resources/biganimal_cluster/single_node/resource.tf # pkg/provider/resource_cluster.go
# Conflicts: # examples/resources/biganimal_cluster/ha/resource.tf # examples/resources/biganimal_cluster/single_node/aws/resource.tf # examples/resources/biganimal_cluster/single_node/azure/resource.tf # examples/resources/biganimal_cluster/single_node/bah_aws/resource.tf # examples/resources/biganimal_cluster/single_node/bah_azure/resource.tf # examples/resources/biganimal_cluster/single_node/bah_gcp/resource.tf # examples/resources/biganimal_cluster/single_node/gcp/resource.tf # examples/resources/biganimal_cluster/single_node/resource.tf # pkg/models/cluster.go # pkg/provider/data_source_cluster.go # pkg/provider/resource_cluster.go
wai-wong-edb
approved these changes
Aug 2, 2024
|
closed. Done in PR #570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
VolumeSnapshotsupport in the TF provider.