Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform plan diff improvements #123

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

serdardalgic
Copy link
Contributor

@serdardalgic serdardalgic commented Jan 24, 2023

This PR addresses some of the problems mentioned in #98

  • allowed_ip_ranges and pg_config will be TypeSet because their order might change and that had generated unnecessary changes in the plan output This has been moved to fix: Make allowedIpRanges and pgConfig TypeSet #128, see the comment below for the reasons.
  • storage throughput value in biganimal_cluster resource is now computed because it is automatically calculated by BigAnimal based on the IOPS input.
  • DiffSuppressFunc is set for IOPS field of the storage. If there is no initial value, and it already has a set value in the state, it won't show any diff for this field.

These changes require a Minor bump and they don't require any state migrations.

Please review.

@serdardalgic serdardalgic requested a review from nstott January 24, 2023 18:58
@serdardalgic
Copy link
Contributor Author

As stated in the Example Major Number Increments section of the Versioning Best Practices document:

Changing attribute type where the new type is functionally incompatible (including but not limited to changing TypeSet to TypeList and TypeList to TypeSet)
would required a Major version bump.

That's why, I'd like to remove this change from this PR and add a separate PR for that change.
We can include that change before a major bump. The next major bump will be our way to 1.0.0 which would (quoting the same document above)

Version numbers above 1.0.0 signify stronger compatibility guarantees, based on the rules above.

Probably we might have some more groundbreaking changes before our 1.0.0 releases, to name a few

@mbiagetti mbiagetti self-requested a review February 2, 2023 17:46
Copy link
Member

@mbiagetti mbiagetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serdardalgic serdardalgic merged commit 25294c7 into main Feb 2, 2023
@serdardalgic serdardalgic deleted the terraform-plan-diff-improvements branch February 2, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants