-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Remove status date in package details for CMS users #965
base: main
Are you sure you want to change the base?
Conversation
Coverage Report
File Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good, depending on the requirements
@tbolt Should we ask Brian on whether we should remove this property altogether? Is it used anywhere? etc etc |
@13bfrancis Can you take a look at this PR? As far as I can tell this is targeted to only remove the status date from rendering on the relevant package details pages. Do you know if this will have any impact outside of those pages? |
Hi, I would not remove this property from the backend, only the frontend. The reason I say this is that as these things go sometimes we may want to continue to track dates in case requirements ever change or if we ever decide to use it for reporting or filtering reasons. |
🎫 Linked Ticket
OY2-31290
💬 Description / Notes
🛠 Changes
Updates
recordDetails
to no longer have the "Status Date" as an object to be renderedmacpro-mako/react-app/src/features/package/package-details/hooks.tsx
Line 126 in d4b2070