-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature (ui): Add an MMDL Notification Banner on Mako Homepage #925
Conversation
Coverage Report
File Coverage
|
@RanyeM: It looks like there's a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The banner looks great! Awesome work. 🎉 The only questions I have are about that stray docs
dir and banner persistence.
* feature: merged with main * feature: added mmdl banner based on if user is signed in * fix: removed docs * fix: faq pops out into another tab and formatted code * fix: PR comments * fix: removed localstorage * fix: updated changes and removed svg * fix: updated changes and removed svg * Improve button text vertical spacing * Replace missing bun.lockb file * Make tests more specific * Don't display banner on FAQ page * Resolve a11y errors by using a landmark wrapper * Prevent mobile menu from overlapping alert banner * Ensure there's no gap between mobile menu and edge * Clean up mobile menu layout --------- Co-authored-by: Gavin St. Ours <[email protected]>
🎉 This PR is included in version 1.5.0-val.100 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎫 Linked Ticket
https://jiraent.cms.gov/projects/OY2/issues/OY2-30885?filter=myopenissues
💬 Description / Notes
A notification banner is created in the Mako application that highlights the new MMDL feature.
The banner should appear only the first time the user accesses Mako after the MMDL feature has been added.
The banner should be dismissible by the user, with a clear and accessible option to close the banner.
Ensure that the banner does not reappear once dismissed by the user, even after subsequent logins.
The design and placement of the banner should align with the existing UI/UX standards of the Mako application.
The “Go to FAQs” button should take you to the section on the FAQ page where the MMDL links are located. The dropdown list should be expanded by default.
🛠 Changes
A notification banner was created in the Mako application to highlight the new MMDL feature.
The banner appears only the first time the user accesses Mako after adding the MMDL feature.
The banner can be dismissible by the user, with a clear and accessible option to close the banner.
banner does not reappear once dismissed by the user, even after subsequent logins.
The design and placement of the banner align with the existing UI/UX standards of the Mako application.
The “Go to FAQs” button takes you to the FAQ page section where the MMDL links are located.