Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(upload-sub-medicaid): add email templates for medicaid spa upload subsequent docs #905

Merged
merged 10 commits into from
Dec 12, 2024
Merged

feat(upload-sub-medicaid): add email templates for medicaid spa upload subsequent docs #905

merged 10 commits into from
Dec 12, 2024

Conversation

jdinh8124
Copy link
Collaborator

🎫 Linked Ticket

https://jiraent.cms.gov/browse/OY2-30712

📸 Screenshots / Demo

Screen Shot 2024-12-06 at 12 14 56 PM
Screen Shot 2024-12-06 at 12 15 03 PM

@jdinh8124 jdinh8124 self-assigned this Dec 6, 2024
@jdinh8124 jdinh8124 added type: FEAT Submit new features status: READY PR is ready for review labels Dec 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.93% 5823 / 8095
🔵 Statements 71.27% 6147 / 8624
🔵 Functions 66.14% 1739 / 2629
🔵 Branches 38.56% 1061 / 2751
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/libs/email/preview/Upload Subsequent Documents/CMS/CHIP_SPA.tsx 0% 100% 0% 0% 5-24
lib/libs/email/preview/Upload Subsequent Documents/CMS/MED_SPA.tsx 0% 100% 0% 0% 5-24
lib/libs/email/preview/Upload Subsequent Documents/State/CHIP_SPA.tsx 0% 100% 0% 0% 4-23
lib/libs/email/preview/Upload Subsequent Documents/State/MED_SPA.tsx 0% 100% 0% 0% 4-23
Generated in workflow #967 for commit 62876d3 by the Vitest Coverage Report Action

@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-kibana December 9, 2024 23:06 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-app December 9, 2024 23:06 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 requested a review from andieswift December 10, 2024 15:29
@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-kibana December 10, 2024 15:33 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-app December 10, 2024 15:33 — with GitHub Actions Inactive
andieswift
andieswift requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@andieswift andieswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯
Just found 2 small things

lib/libs/email/content/upload-subsequent-documents/emailTemplates/MedSpaCMS.tsx Outdated Show resolved Hide resolved
lib/libs/email/content/upload-subsequent-documents/emailTemplates/MedSpaState.tsx Outdated Show resolved Hide resolved
@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-app December 11, 2024 15:36 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-kibana December 11, 2024 15:36 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-app December 11, 2024 15:55 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-kibana December 11, 2024 15:55 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-app December 11, 2024 23:41 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to upload-sub-medi-kibana December 11, 2024 23:41 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 merged commit 345d784 into main Dec 12, 2024
15 checks passed
@jdinh8124 jdinh8124 deleted the upload-sub-medi branch December 12, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asharonbaltazar asharonbaltazar asharonbaltazar approved these changes

@andieswift andieswift andieswift approved these changes

Assignees

@jdinh8124 jdinh8124

Labels
status: READY PR is ready for review type: FEAT Submit new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdinh8124 @andieswift @asharonbaltazar