Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(daypicker functionality) fix daypicker to successfully set date in slot field #731

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

jdinh8124
Copy link
Collaborator

Purpose

Add logic to successfully set date within a slot field. In turn ABP8 dates should now have the ability to be saved/set and appear on page load with saved data.

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-29679

@jdinh8124 jdinh8124 self-assigned this Aug 21, 2024
@jdinh8124 jdinh8124 added type: FIX Submit bug fixes status: NOT READY PR ain't ready labels Aug 21, 2024
Copy link
Contributor

github-actions bot commented Aug 21, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 54.46% 4273 / 7845
🔵 Statements 54.27% 4496 / 8284
🔵 Functions 48.41% 1022 / 2111
🔵 Branches 27.06% 801 / 2959
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
react-app/src/components/RHF/SlotField.tsx 80% 70.96% 66.66% 84.61% 94-96, 157, 189
Generated in workflow #147

@jdinh8124 jdinh8124 marked this pull request as ready for review August 21, 2024 20:31
@jdinh8124 jdinh8124 temporarily deployed to date-picker-fix-kibana August 21, 2024 20:52 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to date-picker-fix-app August 21, 2024 20:52 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 added status: READY PR is ready for review and removed status: NOT READY PR ain't ready labels Aug 22, 2024
@jdinh8124 jdinh8124 temporarily deployed to date-picker-fix-app August 22, 2024 18:57 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to date-picker-fix-kibana August 22, 2024 18:57 — with GitHub Actions Inactive
Copy link
Collaborator

@charmcitygavin charmcitygavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Awesome job figuring this one out, I'm glad it just came down to a change in the slot field!!

Copy link

codeclimate bot commented Aug 23, 2024

Code Climate has analyzed commit a4bb37e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.4% (0.0% change).

View more on Code Climate.

Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.75 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @val status: READY PR is ready for review type: FIX Submit bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants