Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplementation of new-submission without seatool writes and introducing form tests #720

Closed
wants to merge 121 commits into from

Conversation

mdial89f
Copy link
Contributor

Purpose

Describe the problem or feature in addition to a link to the issues.

Linked Issues to Close

Links to issue(s) that are closed by this PR. Be sure to use the phrase "Closes #XXX" for each issue, so they automatically close

Approach

How does this change address the issue?

Assorted Notes/Considerations/Learning

List any other information that you think is important... a post-merge activity, someone to notify, what you learned, etc.

@mdial89f mdial89f marked this pull request as draft August 12, 2024 20:02
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 50.65% 3962 / 7821
🔵 Statements 50.81% 4206 / 8277
🔵 Functions 41.76% 908 / 2174
🔵 Branches 22.83% 649 / 2842
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
lib/lambda/appkNewSubmission.ts 0% 0% 0% 0% 16-19, 18, 21-188, 35-40, 36-39, 41, 44-49, 45-48, 51-59, 61, 63-116, 64-65, 67-72, 68-71, 74-77, 79-89, 91-98, 92-97, 100-113, 109-112, 115, 118-119, 121-187, 122, 124-128, 130-163, 131-162, 165, 168-175, 169-174, 177, 179-184, 186, 190
lib/lambda/processEmails.test.ts 93.33% 100% 62.5% 93.33% 69-73, 85-86, 177
lib/lambda/processEmails.ts 47.91% 37.5% 33.33% 47.91% 70-89, 71-73, 76, 79, 81-88, 96-100, 97-99, 101, 112-144, 113-115, 118, 121-126, 129-139, 130-138, 141, 143, 154, 156-168, 170-177, 171-173, 175-176
lib/lambda/search.ts 96.42% 77.27% 100% 96.29% 29
lib/lambda/sinkChangelog.ts 0% 0% 0% 0% 12-15, 14, 16, 18-40, 19-39, 21-35, 22-34, 25-26, 28-33, 37-38, 42-167, 43-165, 45-164, 48, 48, 51, 54, 57-83, 59-64, 63, 65-67, 69, 69, 72-79, 73-78, 82, 86-157, 88, 91-128, 92-106, 105, 108-116, 110-114, 117-127, 129-149, 130-148, 150-156, 159-163, 166, 169-228, 173-226, 175-225, 178, 178, 181, 184, 187-218, 189-197, 196, 198-217, 199-201, 203, 203, 206-213, 207-212, 216, 220-224, 227
lib/lambda/sinkMain.ts 0% 0% 0% 0% 14-17, 16, 18, 20-51, 21-50, 23-46, 24-45, 27-28, 30-38, 40-41, 43-44, 48-49, 53-120, 67-116, 69-115, 74-77, 76, 80, 84-86, 85, 89-108, 91, 93, 95, 95-103, 97-102, 104-105, 107, 110-114, 119, 122-165, 123-163, 125-162, 127, 130-133, 131-132, 136-148, 142-147, 149-155, 154, 157-161, 164, 167-335, 168-333, 170-332, 172, 175-178, 176-177, 179, 181-199, 183-197, 184-187, 187-195, 189-194, 196, 198, 202-325, 203-311, 204-310, 207-209, 212-214, 216, 218-220, 222-224, 226-228, 230-232, 234-241, 236-240, 243, 245-252, 248-251, 255-269, 259, 261-268, 271-274, 278-307, 282-306, 293-295, 297-304, 299-302, 305, 308, 312-314, 313, 315-322, 316-321, 323-324, 327-331, 334, 337-376, 341-374, 343-373, 346-348, 347, 351-352, 355, 355, 357-365, 359-364, 366, 368-372, 375
lib/lambda/submit.ts 0% 0% 0% 0% 8-73, 9-14, 10-13, 16, 18, 21-26, 22-25, 29-34, 30-33, 37-43, 39-42, 53-72, 54, 56-60, 62-65, 67-71, 75
lib/libs/email/index.test.ts 100% 50% 100% 100%
lib/libs/email/index.ts 91.42% 85% 100% 90.9% 39-40, 210
lib/libs/email/content/new-submission.ts 14.28% 100% 0% 14.28% 12-76, 79-140, 145-203, 206-247, 253-308, 311-376
lib/libs/email/content/respondToRai.ts 11.11% 100% 0% 11.11% 7-65, 68-116, 121-177, 180-223, 228-283, 286-338, 343-398, 401-453
lib/libs/email/content/tempExtention.ts 33.33% 100% 0% 33.33% 6-62, 65-113
lib/libs/email/content/withdawPackage.ts 14.28% 100% 0% 14.28% 7-39, 42-56, 61-94, 97-113, 118-150, 153-168
lib/libs/email/content/withdrawRai.ts 6.66% 0% 0% 6.66% 7-56, 59-102, 107-156, 159-203, 208-257, 260-309, 314-361
lib/packages/shared-types/attachments.ts 96.29% 61.11% 83.33% 100% 68
lib/packages/shared-types/events/app-k.ts 100% 100% 100% 100%
lib/packages/shared-types/events/capitated-waivers.ts 100% 100% 100% 100%
lib/packages/shared-types/events/contracting-waivers.ts 100% 100% 100% 100%
lib/packages/shared-types/events/index.ts 100% 100% 100% 100%
lib/packages/shared-types/events/new-chip-submission.ts 100% 100% 100% 100%
lib/packages/shared-types/events/new-medicaid-submission.ts 50% 0% 0% 50% 72-75, 74, 77, 85-90, 92, 78-80, 82-83
lib/packages/shared-types/events/temporary-extension.ts 100% 100% 100% 100%
lib/packages/shared-types/opensearch/main/index.ts 100% 100% 100% 100%
lib/packages/shared-types/opensearch/main/transforms/legacy-package-view.ts 83.33% 65% 50% 85.71% 11, 49-57, 69-70
lib/packages/shared-types/opensearch/main/transforms/new-submission.ts 25% 100% 0% 14.28% 10-35, 11-34
lib/packages/shared-types/opensearch/main/transforms/seatool.ts 56.16% 59.21% 46.66% 59.32% 22-24, 23, 26-29, 27-28, 44-46, 45, 47-49, 48, 50-52, 51, 53, 57, 60, 63, 80, 104, 114-116, 145, 147-150, 154, 156-159, 190-214, 22-23, 23, 45, 48, 51, 53, 104
lib/packages/shared-utils/package-check.ts 100% 94.44% 85.71% 100%
lib/packages/shared-utils/rules.test.ts 0.89% 0% 0% 0.9% 18-22, 19, 19-20, 20-21, 24-251, 25-73, 26-30, 29, 31-34, 32-33, 35-39, 36-38, 40-46, 41-45, 47-53, 48-52, 54-62, 55-61, 63-72, 64-71, 75-100, 76-80, 79, 81-90, 82-89, 91-99, 92-98, 102-142, 103-107, 106, 108-114, 109-113, 115-123, 116-122, 124-132, 125-131, 133-141, 134-140, 144-185, 145-149, 148, 150-156, 151-155, 157-166, 158-165, 167-175, 168-174, 176-184, 177-183, 187-230, 188-192, 191, 193-202, 194-201, 203-209, 204-208, 210-219, 211-218, 220-229, 221-228, 232-250, 233-237, 236, 238-242, 239-241, 243-249, 244-248
lib/packages/shared-utils/testData.ts 100% 100% 100% 100%
lib/packages/shared-utils/package-actions/rules.ts 50% 0% 0% 50% 18-30, 36-42, 48-52, 58-64, 70-76, 82-89, 94-97, 102-104, 109, 114
lib/stacks/deployment-config.ts 96.66% 92.85% 100% 96.66% 113-115
lib/stacks/email.ts 0% 100% 0% 0% 27, 44, 47-58, 61-114, 116-123, 126-153, 155-176, 165-168
lib/stacks/parent.ts 0% 0% 0% 0% 14, 16-24, 26-29, 31-35, 32-34, 37-41, 43-46, 48-54, 56-59, 61-73, 75-90, 92-107, 109-124, 126-141, 143-147, 149-156, 150-155, 161-162, 166-175, 167-168, 170-172, 171, 174
react-app/src/router.tsx 0% 100% 100% 0% 5, 7-113
react-app/src/components/ActionForm/ActionFormAttachments.tsx 100% 75% 100% 100%
react-app/src/components/ActionForm/index.tsx 33.33% 50% 40% 33.33% 100-132, 101-103, 106-108, 110-112, 114, 116-120, 122, 124-131, 184, 198-199
react-app/src/components/Cards/SectionCard.tsx 100% 100% 100% 100%
react-app/src/components/Inputs/upload.tsx 25.53% 28.57% 20% 26.08% 27-30, 34-37, 44-66, 45, 47-49, 51-57, 56, 60, 62, 64-65, 71-109, 72-73, 76-77, 79-100, 81-99, 82-84, 86-92, 94, 96-98, 103-104, 104, 107-108, 141-142, 142
react-app/src/components/Opensearch/main/useOpensearch.ts 16.66% 0% 0% 16.66% 47-49, 53-71, 54-70, 55-66, 66, 69, 72-74, 73, 75, 78-136, 84-134, 137, 141-143, 145-155
react-app/src/features/forms/new-submission/Chip.tsx 25% 100% 0% 25% 18-89, 48, 79
react-app/src/features/forms/new-submission/Medicaid.tsx 40% 50% 25% 40% 48, 66, 84
react-app/src/features/forms/new-submission/medicaid.test.tsx 100% 50% 100% 100%
react-app/src/features/forms/waiver/app-k/WaiverIdField.tsx 6.06% 0% 0% 6.25% 38-132, 39-41, 43-84, 45-47, 46, 49, 51-52, 54-58, 56, 60-64, 61-63, 66, 68-71, 69-70, 73, 75-80, 76-79, 82, 87-89, 88, 88, 105-107, 141-145, 147-149, 148, 206, 217
react-app/src/features/forms/waiver/app-k/index.tsx 25% 0% 0% 25% 18-96, 88, 90
react-app/src/features/forms/waiver/capitated/Amendment.tsx 20% 100% 0% 20% 17-119, 48, 84, 116
react-app/src/features/forms/waiver/capitated/Initial.tsx 25% 100% 0% 25% 17-92, 57, 89
react-app/src/features/forms/waiver/capitated/Renewal.tsx 20% 100% 0% 20% 17-120, 49, 85, 117
react-app/src/features/forms/waiver/contracting/Amendment.tsx 25% 100% 0% 25% 49, 85, 117
react-app/src/features/forms/waiver/contracting/Initial.tsx 33.33% 100% 0% 33.33% 61, 93
react-app/src/features/forms/waiver/contracting/Renewal.tsx 25% 100% 0% 25% 51, 87, 119
react-app/src/features/forms/waiver/temporary-extension/index.tsx 16.66% 100% 0% 16.66% 22-135, 74-75, 113, 128
react-app/src/features/package-actions/lib/modules/respond-to-rai/index.tsx 42.85% 0% 0% 50% 7-15, 23-32, 36
react-app/src/features/package-actions/lib/modules/withdraw-package/waiver/withdraw-waiver.tsx 44.44% 0% 0% 44.44% 17-22, 24-25, 58-65
react-app/src/features/package-actions/lib/modules/withdraw-rai/index.tsx 57.14% 0% 0% 57.14% 41-58, 62
react-app/src/features/package/package-details/hooks.tsx 13.88% 0% 0% 14.28% 14-17, 16, 28, 28, 44-142, 48, 53, 59, 65, 70, 76-78, 83-84, 86, 92-93, 95, 102, 111, 119, 126, 134, 140, 146-165, 153, 162, 169-178, 174-176, 182-203, 186, 192, 199-201
react-app/src/features/package/package-details/index.tsx 18.18% 0% 0% 18.18% 23, 50-64, 51, 53-61, 57-58, 58-60, 60, 63
react-app/src/features/webforms/WebFormBody.tsx 9.09% 0% 0% 9.09% 19-28, 20-28, 22-28, 24-27, 25-26, 29, 39-44, 46-61, 48, 55-57, 60, 91-94, 97-104
Generated in workflow #183

@asharonbaltazar asharonbaltazar changed the title Reimplementation of new-submission without seatool writes Reimplementation of new-submission without seatool writes and introducing form tests Sep 16, 2024
@13bfrancis 13bfrancis temporarily deployed to form-sub-improvements September 17, 2024 14:53 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to form-sub-improvements September 17, 2024 15:04 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to form-sub-improvements September 17, 2024 15:04 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to form-sub-improvements-kibana September 17, 2024 15:04 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to form-sub-improvements-app September 17, 2024 15:04 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to form-sub-improvements September 17, 2024 15:04 — with GitHub Actions Inactive
@mdial89f mdial89f closed this Sep 23, 2024
@mdial89f mdial89f deleted the spiderface branch September 24, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants