feat(webforms): ABP 8 #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves readability
charmcitygavin
temporarily deployed
to
abp8-app
GitHub Actions
Inactive
charmcitygavin
temporarily deployed
to
abp8-kibana
GitHub Actions
Inactive
charmcitygavin
temporarily deployed
to
abp8-kibana
GitHub Actions
Inactive
charmcitygavin
temporarily deployed
to
abp8-app
GitHub Actions
Inactive
|
Code Climate has analyzed commit ff1814a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.7% (0.0% change). View more on Code Climate. |
|
🎉 This PR is included in version 1.5.0-val.73 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds the ABP 8 webform.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-26330
Approach
sectionsdir to better organize the repeating sections and make things more readablevalueExistscase in the dependency wrapper and applies it to the first checkbox groupLink to Figma: https://www.figma.com/design/SqatGKZlgbftdOM7zMqq08/MMDL-Alternative-Benefit-Plan-(ABP)-Forms-(all)?node-id=3003-11733&t=sS2WE0ZBhYzVppXD-0
There are multiple repeating subsections within main sections in this form, and to wrangle that I created a sections dir that contains the functions needed to return the repeating sections, along with titles, labels, names and dependencies customized for the corresponding section. I left comments with more details in the files themselves.