Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): useCountdown hook #702

Merged
merged 3 commits into from
Aug 2, 2024
Merged

feat(testing): useCountdown hook #702

merged 3 commits into from
Aug 2, 2024

Conversation

asharonbaltazar
Copy link
Collaborator

No description provided.

Copy link

codeclimate bot commented Aug 2, 2024

Code Climate has analyzed commit ff0c1d1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.4% (0.5% change).

View more on Code Climate.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.41% 4214 / 7889
🔵 Statements 53.28% 4443 / 8338
🔵 Functions 47.6% 1003 / 2107
🔵 Branches 26.7% 791 / 2962
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
react-app/src/components/TimeoutModal/index.tsx 14.28% 0% 0% 14.28% 20-23, 26-27, 29-31, 30, 33-40, 34, 37-39, 38, 42-46, 43-45, 44, 48-53, 49-52, 50-51, 55-58
react-app/src/hooks/useCountdown/index.test.ts 100% 100% 100% 100%
Generated in workflow #37


describe("useCountdown", () => {
beforeEach(() => {
vi.useFakeTimers();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about this. But huge win on this faketimer stuff.

@asharonbaltazar asharonbaltazar merged commit 52cf822 into main Aug 2, 2024
18 checks passed
@asharonbaltazar asharonbaltazar deleted the usecountdown-test branch August 2, 2024 19:38
Copy link
Contributor

github-actions bot commented Aug 5, 2024

🎉 This PR is included in version 1.5.0-val.69 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants