Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): Deleting email templates on branch destroy #699

Closed
wants to merge 5 commits into from

Conversation

andieswift
Copy link
Collaborator

@andieswift andieswift commented Aug 1, 2024

Purpose

The plugin generating the email templates for each branch isn’t clearing the templates when the branch is deleted. As a result of this, the email templates created reached their limit and causing deploy failure in master (Mako’s Dev env). This is not a problem in prod because there is only one branch deployed to val/prod, but could potentially become an issue.

Linked Issues to Close

OY2-29014

Approach

  • adding a step to the destroy.yml "Remove CloudFormation templates"
  • getting all the stacks with the template name (copying the code from the deploy.yml)
  • then deleting each stack

Learning

  • tried to use act which seemed promising, but for some reason didn't work with the deploy action & I decided just to check by manually running a delete
    • notes about act: needs docker installation

Screenshots

See, it works ✨

@andieswift andieswift added priority: MED The sooner the better status: NOT READY PR ain't ready labels Aug 1, 2024
@andieswift andieswift self-assigned this Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.78% 4251 / 7904
🔵 Statements 53.62% 4474 / 8343
🔵 Functions 48.22% 1016 / 2107
🔵 Branches 27.09% 803 / 2964
File CoverageNo changed files found.
Generated in workflow #68

Copy link

codeclimate bot commented Aug 8, 2024

Code Climate has analyzed commit b14161a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.7% (0.0% change).

View more on Code Climate.

@andieswift
Copy link
Collaborator Author

I am closing this PR due to this new PR #714 which will make the code unneeded

@andieswift andieswift closed this Aug 8, 2024
@asharonbaltazar asharonbaltazar deleted the oy2-29014 branch August 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: MED The sooner the better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant