Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dep-wrapper-update): update depdency wrapper logic and testing #691

Merged
merged 9 commits into from
Jul 30, 2024
Merged

feat(dep-wrapper-update): update depdency wrapper logic and testing #691

merged 9 commits into from
Jul 30, 2024

Conversation

jdinh8124
Copy link
Collaborator

Purpose

Dependency Wrapper needed to be able to compare values within array fields. As well as setting values based off of array values. This work encompassed testing coverage for the wrapper.

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-29229

@jdinh8124 jdinh8124 added type: FEAT Submit new features status: NOT READY PR ain't ready labels Jul 30, 2024
@jdinh8124 jdinh8124 changed the base branch from master to main July 30, 2024 02:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 52.77% 4093 / 7755
🔵 Statements 52.6% 4309 / 8192
🔵 Functions 45.61% 941 / 2063
🔵 Branches 26.57% 783 / 2946
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
react-app/src/components/RHF/SlotField.tsx 85.71% 75% 75% 91.66% 93-95, 187
react-app/src/components/RHF/dependencyWrapper.tsx 81.08% 70.21% 100% 81.08% 13, 18-21, 24-27, 71-81, 72-75, 77-80, 87
react-app/src/components/RHF/tests/depedencyWrapper.test.tsx 88.23% 100% 77.77% 88.23% 56, 128
Generated in workflow #24

@jdinh8124 jdinh8124 temporarily deployed to dep-wrap-upp-kibana July 30, 2024 17:54 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to dep-wrap-upp-app July 30, 2024 17:54 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 requested a review from daniel-belcher July 30, 2024 18:05
@jdinh8124 jdinh8124 marked this pull request as ready for review July 30, 2024 18:05
@jdinh8124 jdinh8124 changed the title feat(dependency-wrapper-update): update depdency wrapper logic and testing feat(dep-wrapper-update): update depdency wrapper logic and testing Jul 30, 2024
@jdinh8124 jdinh8124 self-assigned this Jul 30, 2024
@jdinh8124 jdinh8124 added status: READY PR is ready for review and removed status: NOT READY PR ain't ready labels Jul 30, 2024
@jdinh8124 jdinh8124 temporarily deployed to dep-wrap-upp-app July 30, 2024 18:10 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to dep-wrap-upp-kibana July 30, 2024 18:10 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to dep-wrap-upp-app July 30, 2024 19:16 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to dep-wrap-upp-kibana July 30, 2024 19:16 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 merged commit f09d054 into main Jul 30, 2024
15 checks passed
@jdinh8124 jdinh8124 deleted the dep-wrap-upp branch July 31, 2024 16:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

🎉 This PR is included in version 1.5.0-val.69 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-belcher daniel-belcher daniel-belcher approved these changes

Assignees

@jdinh8124 jdinh8124

Labels
released on @val status: READY PR is ready for review type: FEAT Submit new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdinh8124 @daniel-belcher