-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(text-changes-appk): Fix the language in app-k forms to match legacy application #689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have you explored leveraging the other components that also show ProgressLossReminder
? There's a prop (I added it) called hasProgressLossReminder
. Maybe it's worth maintaining consistency.
Language changed! |
Code Climate has analyzed commit 95c9d68 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 90.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 39.9% (0.0% change). View more on Code Climate. |
🎉 This PR is included in version 1.5.0-val.68 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
The purpose of this PR is to change the text in app-k forms to line up more accurately with what is in the legacy application.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-28381