Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-changes-appk): Fix the language in app-k forms to match legacy application #689

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

13bfrancis
Copy link
Collaborator

Purpose

The purpose of this PR is to change the text in app-k forms to line up more accurately with what is in the legacy application.

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-28381

Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you explored leveraging the other components that also show ProgressLossReminder? There's a prop (I added it) called hasProgressLossReminder. Maybe it's worth maintaining consistency.

@13bfrancis
Copy link
Collaborator Author

hasProgressLossReminder

Language changed!

Copy link

codeclimate bot commented Jul 31, 2024

Code Climate has analyzed commit 95c9d68 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 39.9% (0.0% change).

View more on Code Climate.

@13bfrancis 13bfrancis merged commit a038fa5 into master Jul 31, 2024
15 checks passed
@13bfrancis 13bfrancis deleted the appk-text branch July 31, 2024 17:12
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.68 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants