feat(ui): show 1915(c) Appendix K Package Details for withdrawn children #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header-kibana
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header-kibana
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| itemResult: ItemResult; | ||
| }; | ||
|
|
||
| export const PackageDetails = ({ itemResult }: PackageDetailsProps) => { |
There was a problem hiding this comment.
Function PackageDetails has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header-kibana
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header-kibana
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
|
Code Climate has analyzed commit ace51e8 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 11.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 39.9% (0.0% change). View more on Code Climate. |
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
child-appk-header
GitHub Actions
Inactive
|
ignore code climate |
|
🎉 This PR is included in version 1.5.0-val.68 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Show a
1915(c) Appendix K Package Detailsheader for withdrawn Appk children. Previously, it was hard to associate the packages from their parent because nothing was tying them (other than an object in the package changelog).Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-28784
Approach
appkParent: trueto object when it's created to signify its new independent statustitlevariable into component and remove unnecessary hook call by passing down props