fix(ui): enable super user ID editing

[asharonbaltazar]

Purpose

This PR addresses a critical bug which prevented super users from submitting ID edits.

However, since I've changed the way the user is routed to /details in #644, this meant that redirecting the super user back to the /details/:authority/:updatedId needed to be addressed as well.
After studying the logic, I realized that it can be simplified to a single function called getOriginForm. It will determine where the action originated from and append the appropriate tab if needed. This new direction required me to change the origin params and update multiple forms.

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-29122

Approach

• give the useOrigin hook a new identity – introducing getFormOrigin:
  • First, it made no sense it was a hook since it didn't interact with the component's lifecycle. Calling new URLSearchParams(window.location.search) in any submit function would serve the present URL params. The old code had to deal with hook limitations (can't call in other functions, cannot be conditional, etc.) for no reason.
  • Second, the ORIGIN param had to be mapped to a route. This decision added another complexity since the ORIGIN param itself could just be a route, circumventing the mapping entirely.
  • Third, since :authority wasn't a param and thus inaccessible in some cases, useOrigin wasn't equipped to redirect the user to the appropriate route.
  • All in all, redirecting a user meant each form component had four or five imports dedicated to determining the correct destination. getFormOrigin, thanks to ORIGIN param changes and improvements from fix(ui): waivers tab fix #644, can now determine where to redirect the user. Redirecting a user to /details means we have to provide the correct :authority and :id params. Redirecting a user to the correct dashboard tab means we have to provide the correct authority. The function isn't that intelligent, but it's a small price to pay, IMO, for simplicity and maintainability.
• update all forms previously using useOrigin to use getFormOrigin
• update CheckDocumentFunction for updated IDs to poll until a new timestamp is detected
• lift some arguments from submitActionForm into onSubmit in ActionForm for separation of concerns
• fix the ID editing form by including the missing id property

[codeclimate]

Code Climate has analyzed commit 6109b46 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 16.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 39.9% (0.1% change).

View more on Code Climate.

[benjaminpaige]

Looks a lot cleaner to me. just make sure it gets tested before merging. and then please do not start any more tickets today.

[github-actions]

🎉 This PR is included in version 1.5.0-val.66 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀