feat(ABP 5) Add the ABP 5 web form #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmcitygavin
temporarily deployed
to
tigertwo-kibana
GitHub Actions
Inactive
charmcitygavin
temporarily deployed
to
tigertwo-kibana
GitHub Actions
Inactive
# Conflicts: # src/services/api/webforms/index.ts
charmcitygavin
temporarily deployed
to
tigertwo-kibana
GitHub Actions
Inactive
|
🎉 This PR is included in version 1.5.0-val.32 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds the ABP 5 web form to the application.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-26329
Approach
Repeating subsections
In order to avoid repeated code, I created a
subsectionfunction that returns the subsection form and handles custom titles, descriptions, header slots, and name prefixes for the data.There is also a new
subsectionparameter for sections to change the style to a gray background. This may be refactored into a separate component in a future ticket.Dependencies within
FormGroupThis PR also adds a
DependencyWrapperto slots withdependencyproperties to ensure that Select menus with child Input components show and hide as expected.Assorted Notes/Considerations/Learning
In Figma, there are optional subsections with checkboxes in the headers toward the bottom of the form. We are going to discuss these sections with HCD and determine whether or not we can use the existing Checkbox component coupled with the existing child logic rather than create a new component. If we do decide to create a new subheader component with a checkbox included, we will create an additional ticket.
There is also an additional ticket for examining and creating the "Collapse" functionality of subheaders.