Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added moenage stuff #1787

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

added moenage stuff #1787

wants to merge 6 commits into from

Conversation

TheNoumanDev
Copy link
Member

@TheNoumanDev TheNoumanDev commented Dec 23, 2024

ticket: #1773

Right now creating script for Build system for all configurations related to updating gradle, manifest and kotlin files needed for moenage. Also for iOS.

Wot is implemented for Moenagage is:

  • Push Notifications
  • Events
  • InApp Notifications

@TheNoumanDev TheNoumanDev marked this pull request as ready for review December 24, 2024 12:26
final _errorMsg = "MoEngage module is not enabled. Please review the Ensemble documentation.";

MoEngageModuleStub() {
throw RuntimeError(_errorMsg);
Copy link
Collaborator

@snehmehta snehmehta Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stubs initialise shouldn't be throwing module is not enabled error. This will run in every non moengage apps

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@@ -138,12 +154,15 @@ class NotificationManager {
} on Exception catch (e) {
print("NotificationManager: Error receiving notification: $e");
}
print("----------");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either convert it to debugPrint or remove it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -141,6 +141,7 @@ dependencies:
flutter_slidable: ^3.1.1
accordion: ^2.6.0
session_storage: ^0.0.1
moengage_flutter: ^8.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure when you make a build for both android and IOS to test it does not need any app entitlement

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For iOS, have texted you about testing.

  • For android, I am not sure, wot entitlement is mentioned here, but it you are talking about configurations, while making build we have to update the following files for android for which I have created script:

  1. ensemble.config: for adding moenagageAppID
  2. app level gradle file to include moenageSDK implementation
  3. Manifest file
  4. MainActivity.kt and also add 2 new .kt files for handling notifications callback functions.

@TheNoumanDev
Copy link
Member Author

Have Also removed moengageEvents action, and merged it with logEvent action and different it with provider property whose default is firebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require Moengage Module integration for Push Notifications, In App Notifications and events
2 participants