-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added moenage stuff #1787
base: main
Are you sure you want to change the base?
added moenage stuff #1787
Conversation
final _errorMsg = "MoEngage module is not enabled. Please review the Ensemble documentation."; | ||
|
||
MoEngageModuleStub() { | ||
throw RuntimeError(_errorMsg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stubs initialise shouldn't be throwing module is not enabled
error. This will run in every non moengage apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
@@ -138,12 +154,15 @@ class NotificationManager { | |||
} on Exception catch (e) { | |||
print("NotificationManager: Error receiving notification: $e"); | |||
} | |||
print("----------"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either convert it to debugPrint or remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@@ -141,6 +141,7 @@ dependencies: | |||
flutter_slidable: ^3.1.1 | |||
accordion: ^2.6.0 | |||
session_storage: ^0.0.1 | |||
moengage_flutter: ^8.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure when you make a build for both android and IOS to test it does not need any app entitlement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
For iOS, have texted you about testing.
-
For android, I am not sure, wot entitlement is mentioned here, but it you are talking about configurations, while making build we have to update the following files for android for which I have created script:
ensemble.config
: for adding moenagageAppID- app level gradle file to include moenageSDK implementation
- Manifest file
MainActivity.kt
and also add 2 new.kt
files for handling notifications callback functions.
Have Also removed |
ticket: #1773
Right now creating script for Build system for all configurations related to updating gradle, manifest and kotlin files needed for moenage. Also for iOS.
Wot is implemented for Moenagage is: