Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_fail option to integrity for nextflow to not die #371

Merged
merged 1 commit into from
May 22, 2024

Conversation

MatBarba
Copy link
Contributor

Add a --no_fail argument to the check_integrity.py script. The default behaviour is still to fail when an integrity fails (most notably for the genome loader).

This PR changes the default manifest integrity Nextflow module to use that --no_fail option so as to not kill the whole pipeline when an integrity check fails. Instead, integrity.out files are created in each folder and only kept if there have been errors. .

Impacted pipelines: prepare_genome, additional_seq_prepare, dump_files

PS: We should think about writing a final report (sent by email or printed to screen/file) to show what went wrong at the end of a pipeline.

@JAlvarezJarreta
Copy link
Contributor

Regarding the final report, I believe @Dishalodha was looking into something on those lines a couple of months back.

Copy link
Contributor

@vsitnik vsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thank you!

@MatBarba MatBarba merged commit e7fbb6d into main May 22, 2024
1 check passed
@MatBarba MatBarba deleted the mbarba/integrity_no_fail branch May 22, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants